commons-beanutils icon indicating copy to clipboard operation
commons-beanutils copied to clipboard

Published 20 hours ago • verified publisher icon apache

BEANUTILS-550: correction of returning default value by StringConverter

Open JKLedzion opened this issue 3 years ago • 2 comments

PR for Jira issue: BEANUTILS-550.

Assignment of default value in StringConverter didn’t work as method getDefault(final Class<?> type), only for String.class, returned null instead of default value. I’ve changed this method to return default value also for String.class.

Could you please review and let me know if this modification is OK?
 I would appreciate any feedback. Justyna

JKLedzion avatar Feb 14 '22 10:02 JKLedzion

@JKLedzion Thank you for the PR. Don't use Javadoc comments for comments that are not Javadoc. Inline comments would be more appropriate.

garydgregory avatar Feb 14 '22 13:02 garydgregory

@JKLedzion Thank you for the PR. Don't use Javadoc comments for comments that are not Javadoc. Inline comments would be more appropriate.

Corrected.

JKLedzion avatar Feb 15 '22 07:02 JKLedzion