Gary Gregory comments

Results 851 comments of


                                            Gary Gregory

JUnit assertThrows

I am ok with Java 8 but others might not be. May you please bring this up on the dev ML? It would be better if using Java 8 would...

Remove commons-collections; Replace FastHashMap with ConcurrentHashMap

-1 due to binary compatibility. Also the POM changes are invalid.

Lang-1465: Fix the ZZ time zone format

-1. Please see the test failures https://travis-ci.org/apache/commons-lang/jobs/589618913

IO-649 - Improve the performance of the contentEquals() methods.

Hi @brettlounsbury. Thank you for your PR and updates. I've sprinkled comments throughout. Performance claims must be backed up somehow, please add a JMH benchmark to the test so myself...

IO-649 - Improve the performance of the contentEquals() methods.

Sorry about the delay, last day of vacation here ;-)

IO-649 - Improve the performance of the contentEquals() methods.

@brettlounsbury May you please rebase on master?

IO-649 - Improve the performance of the contentEquals() methods.

@brettlounsbury Please rebase on master and keep your changes to a minimum, the current change set is for 53 files! Also compare with https://issues.apache.org/jira/projects/IO/issues/IO-670

updating containsKey method in PassiveExpiringMap

I am waiting for the comments from @kinow to be resolved, by @thePatmanMI or another.

IO-543-ReversedLinesFileReader-with-RandowFileAccess-API

Hello @JeanPierrePortier Thank you for the update. You'll want to run a local command line build with just `mvn` which runs the default Maven goal. This will make sure you...

IO-543-ReversedLinesFileReader-with-RandowFileAccess-API

> Yes just seen this (I just launched `mvn verify` command) before pushing and it is not enough... Just run `mvn`