commons-beanutils icon indicating copy to clipboard operation
commons-beanutils copied to clipboard

BEANUTILS-539/BEANUTILS-509: 1.X line, switch WeakFastHashMap for ConcurrentWeakHashMap

Open car-roll opened this issue 3 years ago • 3 comments

Porting the changes made in #56 to the 1.X line

car-roll avatar Sep 01 '21 23:09 car-roll

This will break binary compatibility and I don't see releasing out of 1.x anyway as we are resource-constrained and want to get 2.0 out.

A general comment: This PR adds an extremely complex class (ConcurrentWeakKeyHashMap) with ZERO tests to match, a no-go.

Since this branch is more than likely going nowhere unless there is a security issue to remedy, I would not spend this on this branch.

garydgregory avatar Sep 02 '21 00:09 garydgregory

@garydgregory this issue makes Jenkins totally irresponsive... see https://issues.jenkins.io/browse/JENKINS-60997 such race condition which depends on the garbage collector (because of weakreference) is definitely impossible to reproduce 100% with a unit test. what could be your proposal alternative to fix that?

olamy avatar Sep 02 '21 07:09 olamy

@garydgregory this issue makes Jenkins totally irresponsive... see https://issues.jenkins.io/browse/JENKINS-60997 such race condition which depends on the garbage collector (because of weakreference) is definitely impossible to reproduce 100% with a unit test. what could be your proposal alternative to fix that?

I expect the new classes to be tested thoroughly. I can understand that the whole use case might be hard to reproduce but a whole new class needs a whole new test to match it. Public and protected APIs cannot be changed.

garydgregory avatar Sep 02 '21 11:09 garydgregory