León Orell Valerian Liehr comments

Results 173 comments of


                                            León Orell Valerian Liehr

[early rough draft] GCI: Don't evaluate free const items with impossible predicates

semver concerns etc etc (voiced by Boxy) @rustbot author

BUG: The output results of cargo test and cargo run seem to be different

@rustbot label -needs-triage @rustbot transfer cargo

Allow dropping `dyn Trait` principal

cc @compiler-errors r? @lcnr

Look at proc-macro attributes when encountering unknown attribute

Failed in rollup: https://github.com/rust-lang/rust/pull/142290#issuecomment-2959558493 @bors r-

Look at proc-macro attributes when encountering unknown attribute

I've only briefly looked at the failure but I see a list of something changing order depending on the target (failure here is on dist-i586-gnu-i586-i686-musl), so this is likely *query...

Document HIR ty lowering

Tentatively assigning myself but I invite others to contribute too if I take too long (cuz I prolly won't prioritize this).

Rustfmt duplicate associated type bound in the presence of comment

@rustbot transfer rustfmt

Detect struct construction with private field in field with default

Checking perf due to additional query feeding in the happy path (if I saw that correctly). @bors try @rust-timer queue

deduplicate the rest of AST walker functions

@fee1-dead This had a negative perf impact (found out in rollup https://github.com/rust-lang/rust/pull/142299). Pasting https://github.com/rust-lang/rust/pull/142299#issuecomment-2964373988 below: --- Finished benchmarking commit (294d66c266c83139d525116a1b1addba75f318a4): [comparison URL](https://perf.rust-lang.org/compare.html?start=c6a955468b025dbe3d1de3e8f3e30496d1fb7f40&end=294d66c266c83139d525116a1b1addba75f318a4&stat=instructions:u). ### Overall result: ❌ regressions - please read...