León Orell Valerian Liehr comments

Results 173 comments of


                                            León Orell Valerian Liehr

Allow more `!Copy` impls

Okay, now using `bug!()` (just like in the `Drop` visitor). I've slightly simplified the implementation (making things less awkward) and now point at the self-type in all branches which is...

The allow-by-default lint `missing_copy_implementations` does not honor `!Copy` impls

The compiler only checks if the type implements `Copy` already to return early and not emit the lint diagnostic but it doesn't check if the type implements `!Copy`: https://github.com/rust-lang/rust/blob/4af79ccd5e23c7cbaabcd7aefdda3b715abde606/compiler/rustc_lint/src/builtin.rs#L753

"Convert `match` to let-else" assist

Ah, I just noticed this issue. It's a duplicate / subset? of #11908.

`#[rustc_on_unimplemented]` warning for `Termination` can be misleading

@rustbot claim

const fns cannot have fn pointer arguments that take mutable references, even if they aren't called

The code now compiles successfully. Closing as fixed.

`dyn XXX` had impl `Debug`, but `dyn XXX + Send` can't Debug.

CC #119338 which would fix this I think.

better documentation of reborrowing

Nope, Chalk *is* dead (rust-lang/rust#113303). Its replacement is the “next gen trait solver”. The full quote is as follows (with context added): > > Given that chalk is not going...

Make square bracket `[]` more usable.

I generally like the idea of `TryIndex{,Mut}` but I'm not really sold on `$expr[$expr]_?`. Would `$expr[$expr]_` also be allowed to enable for example `$expr[$expr]_.unwrap_or($expr)`?

Precise capturing

We do