León Orell Valerian Liehr comments

Results 173 comments of


                                            León Orell Valerian Liehr

cargo publish --index bypasses package.publish restrictions

@rustbot transfer cargo

Remove check_mod_loops query and run the checks per-body instead

@bors p=6 move it above the next rollup

[RFC] Add `Option::todo` and `Result::todo`

This has a better chance as an ACP (API change proposal) over at https://github.com/rust-lang/libs-team/issues.

Outputting rustdoc JSON output to stdout instead of file when invoked via cargo

@rustbot transfer cargo

Add InfiniteIterator trait

> Oh, please don't use negative bounds! They are for internal trait solver tests only! > given the negative-impl concern I didn't really look at the negative *impls* (tho adding...

Don't strip shebang in expr-ctxt `include!(…)`

Re. https://github.com/rust-lang/rust/labels/I-lang-nominated: Dear T-lang, I honestly don't know if we should make this change or not. Therefore I hope you might have an answer. The overall context is *frontmatter* and...

Not linting irrefutable_let_patterns on let chains

> I really hope this PR can be merged before the 1.91 release. That's not possible, master is 1.92 already and 1.91 is beta meaning the latter only accepts patches...

Check associated type where-clauses for lifetimes

Now I'm slightly worried that there might be other regressions caused by PR #147713 due to visitors only overriding `visit_generics` to visit where predicates instead of `visit_where_predicate{,_kind}` (they wouldn't really...

Check associated type where-clauses for lifetimes

@bors r+ rollup

Parsing issues around qualifiers and modifiers

I can't lie, `check_fn_front_matter` is beyond scuffed and gnarly with its ">=2 qualifiers rule", just awful. It doesn't compose well and certain diags suffer, too. OTOH, while `check_trait_front_matter` is way...