León Orell Valerian Liehr

Results 173 comments of León Orell Valerian Liehr

> should [IDENT in `name=IDENT`] not be used as a test name? That's a separate point. And I honestly don't know if it's feasible or worth impl'ing this, namely checking...

@Ternvein, that is expected. While *free* constant items may not reference the generics of the outer item, *associated* constant items are allowed to reference the generics of their direct parent...

I'm going double-check every single snippet you posted and reply with my findings shortly.

**`&dyn Trait` default lifetime can be inferred in expressions** * I can confirm that “[…] the default must be inferred” is true by looking at the debug log of rustc...

Could you add a test for where-clauses, too? That would be great! Thanks in advance :)

Sure, for example: ```rs pub const K: Option = None where String: From; ``` And: ```rs pub trait Trait { const C

Note that generic const items don't have an entry inside the Style Guide yet as you might or might not have noticed. However, the formatting should basically follow the new[^1]...

Yeah, seems to need `rewrite_where_clause` somewhere.

Yes, they are part of `generic_const_items` and don't exist outside of the feature.

To make sure I understand the version strategy correctly, in practical terms does this mean we're going to abandon `rustdoc_json_types`'s `FORMAT_VERSION` constant in favor of updating the package version (in...