León Orell Valerian Liehr comments

Results 173 comments of


                                            León Orell Valerian Liehr

Type ascription builtin is silently replaced by rustfmt(?)

@rustbot transfer rustfmt

Use ordinal number in argument error

@bors r+ rollup

cleanup `candidate_should_be_dropped_in_favor_of`

@lcnr, I just went through the crater reports of all 47 “unknown” regressions. Some of them were spurious (no space left on device), all of the the remaining ones are...

Panic if `PathBuf::set_extension` would add a path separator

@bors retry (yield to rollup which includes this PR and which just failed due to network issues)

Rustdoc should indicate variance on lifetime/type parameters

We've discussed this today in a rustdoc meeting. The rustdoc team is generally in favor of providing this information but it's still unclear how exactly we want to present it...

The lint `unused_doc_comments` classifies all kinds of `#[doc …]` attributes as documentation comments

Revisiting this, I'm inclined to emit `unused_attributes` for those kinds of doc attrs but I guess it's a bit weird to emit a rustdoc-specific lint in one situation and a...

Reword "object safety" as "trait-object safety"

Competing PR: #1666.

Dont consider predicates that may hold as impossible in `is_impossible_associated_item`

Out of curiosity due to classic→next: @bors try @rust-timer queue

[perf] Tweak `GenericArgs`-related functions

@bors2 try @rust-timer queue

[perf] Tweak `GenericArgs`-related functions

I want to check what happens if I only do the `assert_matches` → `debug_assert_matches` change since I can't quite tell from the self-profile and the query trace if that's the...