León Orell Valerian Liehr
León Orell Valerian Liehr
NB: Since the stabilization of GATs, rustc syntactically accepts both where-clause locations (before, after, before & after). I don't know how syn usually fares in these kinds of situations but...
I've got a better idea. It'll take a bit of time to impl but I predict it'll be a lot more fruitful and actionable. Namely, instead of trying to crater-run...
Closing in favor of https://github.com/rust-lang/libs-team/issues/371.
Technically speaking this is a breaking change though isn't it? If a pre-existing crate exposes a derive macro with a helper attribute `skip` and errors on `#[skip(Debug)]` for example, existing...
Revisiting this I think we should be more careful with introducing more and more unnamespaced helper attributes. If we continue this trend (`#[default]`, `#[skip]`, etc.) we end up digging our...
cc @petrochenkov (you might be interested in this topic)
https://github.com/rust-lang/libs-team/issues/334#issuecomment-1942951274: > Ah, furthermore, the feature gate error alone can also break existing packages. To give an update (at long last), the [crater report](https://github.com/rust-lang/rust/pull/121053) did confirm my suspicion. We have...
And rust-lang/rust#122806 made the macro `type_ascribe` use `builtin # type_ascribe`.
`rustc_ast_pretty` does print `builtin # offset_of` and `builtin # type_acribe` correctly (well, it prints `builtin # type_ascribe` as `type_ascribe!` but I'm gonna fix that, too), only `rustfmt` doesn't. `rustfmt` actually...
Moving it back to the rustfmt repo since this is strictly rustfmt-related (wrong output for `type_ascribe`, panic on `offset_of`) as AST pretty works perfectly fine. @rustbot transfer rustfmt