rustc-dev-guide icon indicating copy to clipboard operation
rustc-dev-guide copied to clipboard

Document HIR ty lowering

Open nikomatsakis opened this issue 7 years ago • 10 comments

[!NOTE] The issue description has been rewritten by @fmease.


See its API docs: https://doc.rust-lang.org/nightly/nightly-rustc/rustc_hir_analysis/hir_ty_lowering/index.html.

The chapter should explain:

  • [ ] Meaning & origin of its current name (HIR ty lowering) and of its previous name (astconv).
  • [ ] Purpose, incl. bigger picture
  • [ ] "Conventions", "restrictions", "self imposed rules" (e.g., https://github.com/rust-lang/rust/pull/125819#issuecomment-2142394608).
  • [ ] "Limitations" (cc arbitrary shorthand projection & inherent associated type debates)

nikomatsakis avatar Aug 08 '18 21:08 nikomatsakis

@mark-i-m @nikomatsakis Shall I take this issue to work on?

rajcspsg avatar Jan 18 '19 03:01 rajcspsg

That would be great, but unfortunately I won't be able to offer much guidance, as I don't really know anything about astconv.

mark-i-m avatar Jan 18 '19 03:01 mark-i-m

e81386 The link provided by @nikomatsakis is not available or I don't have permission.

rajcspsg avatar Jan 18 '19 04:01 rajcspsg

Hmm... unfortunately, I don’t really know what to do here. Sorry about that...

mark-i-m avatar Jan 18 '19 04:01 mark-i-m

@rajcspsg I'm not sure what it said at that link anymore either =) Probably it was just a summary of how "astconv" contains some logic for converting the types from the "AST form" to the internal, semantic form

nikomatsakis avatar Jan 18 '19 21:01 nikomatsakis

maybe reach out on the rust-lang zulip and we can discuss more?

nikomatsakis avatar Jan 18 '19 21:01 nikomatsakis

Triage: astconv isn't a thing anymore AFAIK, it's probably now called ast_lowering.

jieyouxu avatar Nov 04 '24 11:11 jieyouxu

Nope, it's called HIR ty lowering

fmease avatar Nov 04 '24 11:11 fmease

(For easier reference, the PR that renamed it is https://github.com/rust-lang/rust/pull/120926)

jieyouxu avatar Nov 04 '24 11:11 jieyouxu

Tentatively assigning myself but I invite others to contribute too if I take too long (cuz I prolly won't prioritize this).

fmease avatar Nov 04 '24 11:11 fmease