Robert Findley

Results 271 comments of Robert Findley

I think @hyangah may already be working on this.

Hi, thanks for filing this issue. This has come up before, and we feel that it is helpful to be able to jump to symbols in the standard library or...

@ewen-lbh we have spent some time recently optimizing the initial workspace symbols request. In Kubernetes, for example, we have optimized it from ~5s down to ~500ms. What is your `gopls`...

> Here is some information that might be relevant to my workspace size: I have 6584 lines of Go code spread across 36 files, which are part of three different...

> +1, red color confuses with a real error Unused variables *are* real errors in Go though. From the spec (https://go.dev/ref/spec#Variable_declarations): "Implementation restriction: A compiler may make it illegal to...

There is a mechanism to do this. go/types has a notion of a 'soft' error: https://pkg.go.dev/go/types#Error (which is approximately an error which is optional for the implementation). The errors we're...

Hi, thanks for this issue. IIRC, variable interpolation in settings.json is a bit hacky / ad-hoc (see for example https://github.com/golang/vscode-go/issues/2310#issuecomment-1176284842, and the change resolving that issue). This does seem like...

Ok, we discussed this in the team meeting, and unfortunately would like to put this on the back-burner for now. The reason is that the current handling for variable interpolation...

@JeySamir just following up: could you *please* try to capture logs reproducing the problem? From the repro you describe, it looks approximately like a line ending edit from an old...