Fionn Malone comments

Results 134 comments of


                                            Fionn Malone

Use QROAMClean in Chemistry Sparse Prepare bloq

> I'm sort of troubled that all the tests passed given that there are sparse walk operator examples... After talking to @tanujkhattar Point 1 is not valid, we're not feeding...

Use QROAMClean in Chemistry Sparse Prepare bloq

@tanujkhattar the -2 difference stems from the -8 (/4 = -2) term in our QROAM which isn't in the openfermion calculation. My guess is ours is more correct? Do you...

Use QROAMClean in Chemistry Sparse Prepare bloq

I guess they just drop the constants

Use QROAMClean in Chemistry Sparse Prepare bloq

@tanujkhattar there was a hot fix in there (the most recent commit) related to point 1. which became an issue. My fix was to take the union of the selection...

Use QROAMClean in Chemistry Sparse Prepare bloq

Whoops, auto-merge did its thing. I'll make the same change with THC shortly so can revert then if problematic.

Use `PRGA` in double factorization `ProgRotGateArray`

I don't think this is actually equivalent. PRGA acts on a single target but this one needs to act on multiple targets. Ideally would be unified with the THC bloq...

Use `PRGA` in double factorization `ProgRotGateArray`

Perhaps an intermediate step would be to not name this ProgRotGateArray and use something like #579 which may be a lot closer to having a real implementation given all the...

Add n-bit Identity, implement C[I] = I

Does OnEach not capture nbit identity? On Mon, Jul 29, 2024 at 4:47 PM Matthew Harrigan ***@***.***> wrote: > I ran into this trying to do bloqs-only resource counting of...

mean_estimation.complex_phase_oracle_test.test_phase_oracle is very slow because of Fxp

I never dug into what was the cause of the slowness, whether it was Fxp or whether it was something else.

Implement `alpha` and `epsilon` for chemistry `BlockEncoding`s

Is it well understood what epsilon should be for these methods which have multiple epsilon contributions.