Fionn Malone

Results 134 comments of Fionn Malone

chemistry should maybe be further organized as chemistry/qubitization and chemistry/trotter

I think ascii math seems fine, some latex support could be nice down the line.

Add bloq for adapative phase estimation. xref: #753. refs: https://journals.aps.org/pra/abstract/10.1103/PhysRevA.80.052114 https://www.nature.com/articles/nature06257

QROM yes (I think). For SelectSwapQROM where I've seen this in the literature they typically form a contiguous index from the multi index and do 1D array access if I'm...

I'm still a little confused about why the Identity being a single qubit bloq is problematic, does`OnEach(Identity(), n).controlled(m)` not do the same thing?

Ok, should this still be a basic gate? I think the justification for moving it back to basic gates from #1322 was that it was more logically consistent to be...

SGTM. Do we need to have both? Probably not right?

I guess on 2 I could call _build_composite_bloq, pick out the QROAM bloq and handle then handle the register mapping.

I'm sort of troubled that all the tests passed given that there are sparse walk operator examples...