Fionn Malone
Fionn Malone
Copying this over from the closed PR (#615) for visibility / continue the conversation. > Thank you for your detailed answer, now the tensor contract works. > > Also, I...
right, that is the plan once we sort of land on what bloqs work on which types.
Would specifying a dtype for OnEach solve the problem?
A somewhat hacky fix would be to add an optional dtype to the constructor and then use that if it's not None, or add a specialized version for typed registers.
Another solution would be a factory method, but this would also require every call site to be changed I think.
- [ ] Splits and joins
Given the lower qubit count and higher toffoli count my guess is that the correct QROAM is not being used (I believe https://github.com/quantumlib/Qualtran/pull/1378 is not in v0.5 of qualtran) so...
I'll look into this
@vinayswamik how big a difference are you seeing? The lambda value will be grossly wrong if used directly from the randomly generated coefficients, but this only matters for phase estimation....