Fionn Malone
Fionn Malone
From #869 we see some regression with FQE in the sense that the Taylor series might not converge. It's not clear when this broke or if it's a flaky numerical...
Should fix this and use it as an opportunity to test the slow tests.
the variable nprime has the second term divided by 4 instead of 2 https://github.com/quantumlib/OpenFermion/blob/a034397a13b1ea224e11746d4ee368cccf2bc962/src/openfermion/resource_estimates/sf/compute_cost_sf.py#L72 as per eq. B13. The inverse QROM should be on two registers (QI2) not one (QI).
the costing function computes br for outer prepare and inner prepare differently: https://github.com/quantumlib/OpenFermion/blob/a034397a13b1ea224e11746d4ee368cccf2bc962/src/openfermion/resource_estimates/df/compute_cost_df.py#L53 Which would be fine but the br fed into cost two should be using the second (hardcoded...
Working on #841
Is there a simpler way to add a singly-controlled bloq: ``` python ctrl_spec = CtrlSpec(cvs=[0]) (ctrl,), q = bb.add(ZGate(), ctrl=(ctrl,), q=q) ``` seems a little awkward. Is ``` python ctrl_spec...
The notebook tests in the CI seem to randomly fail every so often. Rerunning them seems to work. Any idea what's going on? Heres's a recent traceback: ``` [PosixPath('Adjoint.ipynb'), PosixPath('Autodoc.ipynb'),...
Working on #841, adds a walk operator example for the sparse hamiltonian which fits the usual select and prepare construction. Just adds an example and some autodoc. ~~I have an...
Currently rendering something like QROM as a nice bloq_counts picture requires a bit of hackery (see below). What I have done below also seems wrong, our bloqs are frozen but...
Added a function in #602 which has the limitation that it only works if the register's shape=(). wire_symbol method probably shouldn't use the binst field.