Fionn Malone
Fionn Malone
The source of the disagreement is outlined here: https://github.com/quantumlib/Qualtran/issues/390, now might be a good time for me to revisit this given that the library has evolved so much since then.
I think this is related to #1351. There's some inconsistency currently with piping through all the junk registers when building the walk operators
cc @linusjoonho
I will split this up into ~ 5 PRs. This is the final state roughly with the tests passing locally on my machine.
closing this following #357. Phew. @wjhuggins please update as appropriate for better docs around shadow tomography.
xref #346
Can probably close it, it wasn't addressed, but it would be @wjhuggins to add (can't seem to assign him)
@wjhuggins PTAL and feel free to add any details you like (high or low level) we can also revisit to add more helpful tutorials for shadow tomography..
@mpharrigan do I need to do anything more to ensure the docs render correctly / regenerate them?