Fionn Malone
Fionn Malone
Comparison between QROAM and SelectSwapQROM, both should scale like d^{1/2}.
code: ``` python import matplotlib.pyplot as plt import numpy as np from qualtran.bloqs.basic_gates import TGate from qualtran.bloqs.chemistry.black_boxes import QROAM from qualtran.bloqs.chemistry.chem_tutorials import plot_linear_log_log from qualtran.bloqs.select_swap_qrom import SelectSwapQROM if __name__ ==...
This is a recent failure I noticed locally too. Must be an upstream change from some dependency.
This certainly looks like an error or should at least be clarified.
This looks like a duplicate of #721, which should definitely be fixed.
What's the issue with the existing adder? In my defense this is a holdover from very early cirq_ft so I'm totally on board with improving it
Maybe I'm missing something but the state of affairs is a little odd:
I know the XGate got missed in #956 but having show_bloq without any bloq information seems wrong?
Should we be doing: ``` diff --git a/qualtran/drawing/graphviz.py b/qualtran/drawing/graphviz.py index 281571e1..54a46a33 100644 --- a/qualtran/drawing/graphviz.py +++ b/qualtran/drawing/graphviz.py @@ -377,7 +377,9 @@ class PrettyGraphDrawer(GraphDrawer): if isinstance(binst.bloq, (Split, Join)): return '' # This...