Fionn Malone

icon company Google icon location California icon location Software Engineer @ Google

Results 134 comments of Fionn Malone

Added optional params `sub_bit_prec` and `epsilon` to `preprocess_lcu_coefficients_for_reversible_sampling`

You might need to reinstall the requirements, ``` pip install -r dev_tools/requirements/envs/dev.env.txt ```

Add Fxp classical simulation

cc @tanujkhattar, I need to profile why classical simulation is so slow + an alternative to caching BUT the big problem right now is that some of the tests which...

Add Fxp classical simulation

My sneaking suspicion is doing the bitwise algorithm for the paper is slow, @tanujkhattar did you check if Fxp multiplication yielded the same thing as what's in the reference.

Add resource estimation notebook for trotterized QPE

Add resource estimation notebook for trotterized QPE

For sure On Thu, May 9, 2024 at 2:53 PM Matthew Harrigan ***@***.***> wrote: > @fdmalone can you resolve the conflicts? I > think most of them are vestigial from...

`bloq.call_graph()` should preserve ordering of successors across calls / `build_call_graph` should return a Dict instead of Set

^^^ I've been caught out by this before

Add a wrapper bloq to help plug bloqs into each other whose registers don't quite match

it's also possible that this could be added to bloq builder as a utility which would handle some of the boilerplate

Add a wrapper bloq to help plug bloqs into each other whose registers don't quite match

> Since you brought it up: would you be able to come up with meaningful register (soquet) labels so we wouldn't need the `short_name` title? Sure, this is a separate...

SelectSwapQROM T complexity differs from call graph value if block_size > 1

cc @tanujkhattar

Update lcu_util to allow user to specify sub_bit_precision

I don't see why not. In the notebooks I believe we often set epsilon to be $2^{-n_b}$ directly, but it might be a bit more convenient to make this an...