fanquake
fanquake
Looks like `is_bdb_compiled` & `skip_if_no_bdb` should have been dropped.
cc @stevenroose
Generally I would prefer if we weren't making source code changes to fix (currently edge-case) Windows linking errors; especially if there are more complete fixes we could be making (even...
> I'm not sure about the current approach of this change. I agree. There's no rush or need to do anything here, and doing something just to "make things green/compile"...
This seems fine, but it'd be good to primarily list the benefits to our project, rather than justifying making changes based on if some other open source project happens to...
Also added this to `29.x`, as if we are going to change this, it needs to happen along with the CMake switchover, and not be a new breaking change after...
https://cirrus-ci.com/task/6223844022681600?logs=ci#L2898: ```bash [08:40:37.725] + LD_LIBRARY_PATH=/ci_container_base/depends/i686-pc-linux-gnu/lib [08:40:37.725] + test/functional/test_runner.py --ci -j10 --tmpdirprefix /ci_container_base/ci/scratch/test_runner/ --ansi --combinedlogslen=99999999 --timeout-factor=40 --v2transport --quiet --failfast [08:40:38.317] 2025-01-10T13:40:38.202000Z TestFramework (INFO): PRNG seed is: 5569585375096173377 [08:40:38.317] 2025-01-10T13:40:38.206000Z TestFramework (INFO):...
Why are `bitcoin-chainstate` and `bitcoin-util` being put into libexec? `bitcoin-util` is meant to be called by users directly. Not sure why `bitcoin-chainstate` would be put there either?
> The call to RegQueryValueExA in RandAddSeedPerfmon: I think you can open a PR to just remove this entirely.
https://github.com/bitcoin/bitcoin/actions/runs/13718139296/job/38367326902?pr=32015#step:7:1603: ```bash Run p2p_headers_presync with args ['/Users/runner/work/bitcoin/bitcoin/ci/scratch/build-aarch64-apple-darwin23.6.0/src/test/fuzz/fuzz', PosixPath('/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/p2p_headers_presync')]net_processing.cpp:295 SetTxRelay: Assertion `!m_tx_relay' failed. Error processing input "/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/p2p_headers_presync/c12f87158cda99b4fb2e1fe7312af392a1f4634a" net_processing.cpp:295 SetTxRelay: Assertion `!m_tx_relay' failed. Error processing input "/Users/runner/work/bitcoin/bitcoin/ci/scratch/qa-assets/fuzz_corpora/p2p_headers_presync/c12f87158cda99b4fb2e1fe7312af392a1f4634a" ```