fanquake

Results 996 comments of fanquake

> I guess I'm a little confused about how this should work. It seems it's not very consistent. > So.. how should this all work ideally? Do we really need...

Is there any particular motivation (to do this now), given it doesn't work/can't be tested?

Not sure about this issue, or making this change. Looks like it needs more investigation. See my comment here: https://github.com/bitcoin/bitcoin/issues/30978#issuecomment-2388086723.

@dergoegge you likely also have some thoughts here?

Also in `test_deterministic_coverage.sh`: `Run \"./configure --enable-lcov\"`

https://github.com/bitcoin/bitcoin/blob/37679b856ce183ec256c12a680b93ad53ed94da6/doc/design/libraries.md?plain=1#L11

Also needs a release note.

> Surely this isn't the only place env vars like this would cause issues? Feels like a cat-and-mouse game. Yea, as-is this doesn't seem like a great fix, and may...

Is this still an issue given recent CMake changes?