fanquake

Results 962 comments of fanquake

> we would just add support new commands in the [external signer command interface](https://github.com/bitcoin/bitcoin/blob/master/doc/external-signer.md) Can you elaborate on your longer term plans for external signing / Boost Process. Process is...

> This PR aims to reduce the build time. Can you update the PR description to clarify that this is only relevant for native windows builds. Can you also add...

Opened #30881 to track this, given a second dev has reported performance issues.

I think this is a duplicate of #29796? (or at least, it'd be good to try and keep the discussion in one place).

> I saw https://github.com/bitcoin/bitcoin/pull/29796 too, but it seems to be a discussion of which optimization flags are set, not how the flags are set. Sure. If the discussion is in...

> 100% cache hit rate is expected. I tested this, and got about 90%: ```bash ccache -C ccache --zero-stats cmake -B some_build_dir -DWITH_CCACHE=ON cmake --build some_build_dir -j17 ccache --show-stats Cacheable...

> What is your system and Ccache version? That was on a macOS machine, with 4.10.2. Retested just now, and got the same: `Hits: 394 / 445 (88.54%)`.

Just tested the same on a Fedora box (ccache 4.10.2) and ended up with `Hits: 447 / 528 (84.66%)`.

> What if you ccache --zero-stats after configuring for a new build tree, just before building? In that case on Fedora it is `Hits: 446 / 446 (100.0%)`, with `Uncacheable...

Seems like you missed some review comments? https://github.com/bitcoin/bitcoin/pull/30861/files#r1752126150 https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1752127638 Seems like https://github.com/bitcoin/bitcoin/pull/30861#discussion_r1752135299 is now also more relevant given #30905, so it'd be good to know how this is going to...