fanquake

I guess this is also now a follow up for: https://github.com/hebasto/bitcoin/pull/192#discussion_r1660826044.

ACK - post rebase.

Concept ACK - looks like switching this to use CMakes default permissions, rather than ours, does fix the issue, but I guess could use more discussion given: https://github.com/bitcoin/bitcoin/issues/30815#issuecomment-2336699084.

Guix build (aarch64): ```bash 8eeb195889318631934b31746dcbd04b26c2312e2aa29dbd7be9de9581a8b805 guix-build-5ba03e7d35e1/output/arm64-apple-darwin/SHA256SUMS.part 05c10866f6972aa58a379935dbc4eb39a8e2abc54a27aa4fa2ce06a7443593ba guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.tar.gz f81ec9368bf068a373ec88428becdef08533e8984ad95a3b017f7f1a8cbbb5b1 guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin-unsigned.zip cb7b4febe1ccfa7ece2cefaf36dc022a433747045ff0545d9f9fea2f930187ca guix-build-5ba03e7d35e1/output/arm64-apple-darwin/bitcoin-5ba03e7d35e1-arm64-apple-darwin.tar.gz 5b64fd3adb8b1f8541636517d7a2014323197753ae22b4f1596769a8c2208b90 guix-build-5ba03e7d35e1/output/dist-archive/bitcoin-5ba03e7d35e1.tar.gz 386c997bb64b79a59f06533c007f66b3739d640ef01b4faea23a2429bf876643 guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/SHA256SUMS.part 50c4336a4904121aea252e4197f830bdaa1ca08d34ce35a22167725f686cd084 guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.tar.gz 48b4331dc224bd578490b9576943fe41ae0e1ee725e3bd779578772ad744090d guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin-unsigned.zip 291b31673f14c98ab7641cb25a996b98663acae7c83fc2904f974d5e0357714f guix-build-5ba03e7d35e1/output/x86_64-apple-darwin/bitcoin-5ba03e7d35e1-x86_64-apple-darwin.tar.gz ```

Let's also wait for https://github.com/bitcoin/bitcoin/pull/30454#discussion_r1743326932. To clarify if this ever worked (and was later broken?), or was just never expected to work. In either case, it could be worth documenting.

Agree with Cory. I think what we've got currently is ok. We don't need to explicitly allow poeople to compile with any other standard (accidently or not). If someone really...

> A few things still need to be addressed: This PR is also changing the flags used for code generation. Is that intentional? If yes, would be good to mention...

Ok. Well the current changes would be unsafe to merge, and I don't think we should be adjusting our build system to work around the subtree, if anything, we should...

Closing, as the consensus between myself, @hebasto, @theuni and @TheCharlatan was to not make this change (for now, or not until we've adjusted upstream further).

> APPEND_LDFLAGS is not passed to the subtree's build system at all. I thought #30791 fixed an issue related to passing down linker flags via `APPEND_LDFLAGS`. So has that regressed...