fanquake

Results 1060 comments of fanquake

ACK 3f386cc3e31bd049eb0d069644a4d7188053b4bb - just because it would now match what Core is setting, which seems reasonable.

ACK 34f48d1e8f85dcd471c16a14b0bae01c1f2d561d

Removed the label as this isn't being backported.

I wonder if a better approach here would be to further integrate the manpage generation into the build system; given that the two issues of "which binaries exist" and "where...

> The code sign -s - ... command is not required to run downloaded binaries. How are the binaries running if they aren't codesigned at all? If this isn't an...

> Tried on Intel macOS 15.0 (Xcode 16.0) and 13.7 (Xcode 15.2): Tried which code? If this was a clean build, according to the log, it's also skipped building Boost...

Maybe @achow101 or @furszy want to review here?

MSAN failure was spurious, but not the tidy (https://cirrus-ci.com/task/4930868089716736): ```bash [21:49:26.130] clang-tidy-18 -p=/ci_container_base/ci/scratch/build-x86_64-pc-linux-gnu -quiet -load=/tidy-build/libbitcoin-tidy.so /ci_container_base/src/validationinterface.cpp [21:49:26.130] /ci_container_base/src/validationinterface.cpp:22:13: error: redundant 'RemovalReasonToString' declaration [readability-redundant-declaration,-warnings-as-errors] [21:49:26.130] 22 | std::string RemovalReasonToString(const MemPoolRemovalReason& r)...

Closing for now. Could re-open if you want to circle back to looking at this.

Note that this is being reverted in #33063.