Jay Harris
Jay Harris
Use `fork` instead of `origin` ``` git fetch fork git rebase fork/master ```
Kicked it off again :crossed_fingers:
CI is still failing on Windows ``` ../../brave/browser/ui/browser_commands.cc(936,27): error: no matching member function for call to 'push_back' [2024-10-27T21:32:55.855Z] 936 | file_types.extensions.push_back(std::vector{"html"}); [2024-10-27T21:32:55.856Z] | ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~ [2024-10-27T21:32:55.856Z] ../../third_party/libc++/src/include\vector(692,60): note: candidate function not...
Kicked off CI again :crossed_fingers:
Ah sorry, I thought that's actually the behavior you wanted! If you want the shortcut to only work on that page, it'd probably be better to add a shortcut to...
I think the approach is fine for now - I think if you add the shortcut you won't be too surprised if it works from anywhere (and I don't expect...
@hamirmahal yeah that seems like a reasonable approach to me (just taking what that function does). Nice work :smile:
looks good - kicked off CI again :crossed_fingers:
Great work @hamirmahal!
Glad we got it in eventually, sorry for the endless rebase-CI cycles :/ Looks like it made it into todays Nightly!