Jay Harris
Jay Harris
Another thing I just came across was the brave://flags/#brave-web-view-rounded-corners flag, which you might be able to toggle on/off. Not sure it'll help but might be worth trying.
Okay, thanks for all the input everyone - my theory is that this was something that changed in upstream Chromium. Glad its working for you all again :smile:
Interesting - this seems to be related to us hiding the close button 😨
Sorry @petemill it wasn't building when I switched back after the policy stuff landed, so I rebased
@petemill did you see my comments here? https://github.com/brave/brave-core/commit/dc0d55fb1fc4ef818a0e45327438a6de58314f93
Nice work @hamirmahal! If you want to show a FilePicker this seems like a good place to start looking: https://source.chromium.org/chromium/chromium/src/+/main:ui/shell_dialogs/select_file_dialog.h?q=symbol:%5Cbui::SelectFileDialog::Create%5Cb%20case:yes (it sounds like you can pass `nullptr` as the second...
The PR seems to be failing to build on Windows with the following: 
Would you mind rebasing? I just tried to run CI on latest but the rebase failed for conflicts
Ah yeah so in the `brave` repo (probably at `brave-browser/src/brave`): ``` git fetch git rebase --onto origin/master npm run sync npm run build npm run start ``` I think those...
Hmm yeah, maybe do a `git pull` so you don't lose your changes. if you do a ``` git remote -v ``` what does it output? I'm wondering whether its...