Jay Harris comments

Results 161 comments of


                                            Jay Harris

"Quick Commands" were re-enabled when upgrading Brave Nightly

I haven't been able to reproduce either.

fix: prevent parent element onClick from triggering

Hey @brandedcow I don't think the commit before the merge is signed. I would do the following to resign and avoid needing a merge commit: ``` git reset --hard HEAD~1...

fix: prevent parent element onClick from triggering

Sweet, that looks good - unfortunately it'll be a while until we get this one merged 'cause I'll need to bump Nala first (and that's never very quick).

fix: prevent parent element onClick from triggering

@brandedcow once https://github.com/brave/brave-core/pull/24379 lands you'll need to rebase (it'll probably take a few days at least) and I can kick off CI. Sorry its such a process :laughing:

fix: prevent parent element onClick from triggering

Mind rebasing?

fix: prevent parent element onClick from triggering

Whoops forgot about this. ~~I'll just see if I can work out why CI isn't passing.~~ Kicked off CI properly

[Settings]: Change focus outline color

@aguscruiz you're probably the most important reviewer here - this will update all the focus outlines in the Settings pages. We can't easily swap them to use our `--leo-effect-elevation` tokens...

[Settings]: Change focus outline color

@aguscruiz I think lets get this in as a Good Enough fix and work on the proper focus outlines separately, as I think its going to be bigger

[intl]: Add support for PluralStrings without the PluralStringHandler

The built `intl-messageformat.esm.js` is `29k` (`17k` gzipped)

[intl]: Add support for PluralStrings without the PluralStringHandler

Yeah agreed - I was actually just looking for a library to format ICU messages and this was the top result. I think the fact that its potentially on the...