Jay Harris

Hey, just FWIW, maybe we should also make the bar possible to swipe away?

Hey @hamirmahal! Thanks, for you feedback - I agree that it'd be pretty handy, but unfortunately it will probably be quite a bit of work to expose everything the browser...

This PR here adds a few new commands: https://github.com/brave/brave-core/pull/19035 Basically there are a few different bits: 1. Add a new command to `app/brave_command_ids.h` (normally at the bottom with a little...

Hmm, that's weird, normally sync is pretty consistent. (completely understand not wanting to reclone Chromium - its massive)! Can you try: ``` npm run init -- --force -C -D ```...

Yeah that sounds right @hamirmahal. Hmm, could you try manually resetting Chromium (in your `brave-browser/src` folder `git reset --hard ce7f05019fe091c912aa09c989eb3d7d406d0f3c`) And in your brave folder ``` git fetch git rebase...

Ah, the `git pull` should be in `brave-browser/src/brave` - we pretty much soley work in the `brave-browser/src/brave` directory :smile:

okay, that seems super weird - it seems to think you're on the right revision but the `version_info/BUILD.gn` file doesn't exist. If you check, does that folder/file exist? I checked...

Okay that's interesting - it sounds like your Chromium checkout might be in a weird state. I just had a look at the `base/version_info/BUILD.gn` and it looks like its been...

@hamirmahal I had a talk to a few other people and it sounds like maybe something went wrong with the initial checkout? Not sure what to do at this point...

Interesting - I would've thought that would work. If you print out the url and enter it in the browser, do you get the results you expect? `https://libgen.rs/fiction/?q=query&criteria=&language=English&format=epub` looks like...