Jay Harris

Results 161 comments of Jay Harris

Fixed the `>` icon and responded - thanks for the review @simonhong!

@simonhong I've updated this PR to include a feature flag we can use to turn the feature off with :smile:

Okay, so I don't think its a good idea to separate typechecking from the Storybook command - I can't imagine a scenario where you'd want to run Storybook without doing...

@petemill @mherrmann I've updated this PR with a `DONT_FORK_TS_CHECKER` environment variable which forces this feature off, and changed things so it only runs in `dev` mode (which is `npm run...

@mherrmann this has been updated on top of the changes from https://github.com/brave/brave-core/pull/21443

*Note:* audit failure is unrelated to this PR https://github.com/brave/brave-core/pull/22761 should fix it

@petemill mind taking another look? @aguscruiz did some work on the designs and I've updated with the origin of the tab and the `No matches` placeholder. The `ButtonMenu` positioning is...

> The "no tabs" UI state is covering the input box. It would be nice to have a consistent position for the popup. But everything else looks good. This was...

Favorites (expanded): ![Image](https://github.com/user-attachments/assets/c728db42-db51-41e4-bb47-038a85de62d6) Favorites (collapsed): ![Image](https://github.com/user-attachments/assets/7c7a1d71-6734-4dac-b530-ab18737e3af1) (expect `+` button to be visible)