Davide Faconti comments

Results 443 comments of


                                            Davide Faconti

Added a new cmake_build for generating a debian

Is this change tested on Windows? We don't want to break it there

Allow letting value field empty for numeric ports

Unit tests are failing. Please remember to run the tests before submitting a PR :)

Is there any library or tool available to visualize BehaviorTree.CPP XML files as images?

Groot can't be used like that, so, from my side, the answer is "no"

Add type & value fields to primitive json types

1. Is this change back-compatible with the previous JSON format? 2. Can we opt-out if people don't want to use this format?

No Input/output port order anymore in writeTreeNodesModelXML ?

The correct solution, in my opinion, is to presere the order of the ports as it was described in **providedPorts**. Unfortunately, this means that we need to apply a change...

BT action client of type nav2_msgs::action::NavigateToPose sends ActionNodeErrorCode SEND_GOAL_TIMEOUT

please try branch **issue_76** and let me know if problem persists

BT action client of type nav2_msgs::action::NavigateToPose sends ActionNodeErrorCode SEND_GOAL_TIMEOUT

I need a way to reproduce this. Is there any dummy server and client that can be used to reproduce the error? It seems to me like a potential error...

Bugprone Tick time monitoring

you are welcome to submit a PR to address this.

Bug when using Parallel Node

More likely the problem is in the ROS subscriber node, not in Parallel. I will investigate.

Add the ability for ros actions nodes to get access to the action result even on failure

looks good to me. thanks again