BehaviorTree.CPP icon indicating copy to clipboard operation
BehaviorTree.CPP copied to clipboard

No Input/output port order anymore in writeTreeNodesModelXML ?

Open RhysMcK opened this issue 1 year ago • 1 comments

Hi,

I notice in this commit d5ea17b5184feacac3f3763de0730713384bafc9 you removed the input/output port ordering logic. As a result, when using writeTreeNodesModelXML() to auto-generate the <TreeNodesModel> tags for Groot2, the ports are in some ?random? order. This is than obviously reflected in Groot2 and not ideal. What was the rational behind removing this?

image

Thanks very much!

RhysMcK avatar Jul 26 '24 05:07 RhysMcK

The correct solution, in my opinion, is to presere the order of the ports as it was described in providedPorts.

Unfortunately, this means that we need to apply a change that breaks the API / ABI.

In the meantimes, can you test the changes here: #870

facontidavide avatar Sep 21 '24 10:09 facontidavide