Ethan Blackwood

Results 117 comments of Ethan Blackwood

Hey @knod, I don't think this is closed actually. What I meant by this issue was to plug in references to the localization object in place of string literals in...

My impression was that #500 is to actually translate existing English strings into other languages, whereas this issue is to factor remaining string literals in the rest of the codebase...

Idk, that seems like sending mixed messages. How would we simultaneously communicate "you should make sure you didn't miss anything on this page" and "you can come back if you...

OK, so although I don't think it'll make any difference in appearance, I'm onboard with the idea of this for semantics. The first part of the predictions page where you...

Not sure exactly what renamings you're suggesting, but I think you should go with whatever seems right to you, at least to make the PR.

So you're saying you were planning on pulling both the `` and `` as they are now out into ``? Just to make sure I understand.

I think only one more change is needed - separating `SpaceHolder`, `FormBottomRow`, and `FormPartsContainer` into `FormPartsContainer.js`, and probably leaving the last 3 together (which are `ExternalLink`, `AttentionArrow`, and `InvalidMessage`. I...

Actually, @knod suggested that this might be a good thing for someone new to the project to try instead.

Sure, no worries! I also haven't used that module before today. Thus I'm not 100% sure there won't be issues with it, but so far it seems pretty straightforward. If...

Updating this now. FWIW I think being able to pass in an existing dview is more important than the async_local backend. I have mostly just been using the local backend...