codeforboston
Refactor formHelpers.js
Long time coming. 'formHelpers.js' is way too long [Edit: and that's a really unhelpful file name]. I'm going to start working on how to break out this stuff into categories that make sense. My plan is still to have multiple components in a file, just to have files that are more specific to function.
[Edit: And to completely get rid of 'formHelpers.js'.]
I'm going to take a break from this while I'm shaking the tree elsewhere. Let's see if someone else wants a crack at it for now.
I think only one more change is needed - separating SpaceHolder, FormBottomRow, and FormPartsContainer into FormPartsContainer.js, and probably leaving the last 3 together (which are ExternalLink, AttentionArrow, and InvalidMessage. I can do this. I'm trying to think of a good name for the remaining components - textHelpers? textElements? Something else?
Actually, @knod suggested that this might be a good thing for someone new to the project to try instead.
Took a look at this with an eye to doing whatever needs done, and as far as I can tell it seems like the tasks @ethanbb called out above (namely separating SpaceHolder, FormBottomRow, and FormPartsContainer into FormPartsContainer.js and leaving ExternalLink, AttentionArrow, and InvalidMessage in formHelpers.js) have already been accomplished.
@knod what is the little bit more work that needs doing here?
@skudbucket : If all we do is find a more useful name than 'formHelpers', that seems good to me. The rationale is that the name isn't descriptive (in my opinion). I just haven't thought of a good name that covers those functionalities. I'm open to other perspectives, though, so let me know your thoughts.
P.S. ExternalLink is being moved out of there already, btw, since non-form stuff uses it. #707 just needs a bit of adjustment.