cliff-effects icon indicating copy to clipboard operation
cliff-effects copied to clipboard

Make all text in the app translatable

Open ethanbb opened this issue 7 years ago • 7 comments

We want to factor out any and all strings in the interface into localization structures (like the one in src/localization/en.js) in order to let the whole app be translated into whatever languages we want/can. We also need to pass the translate function down to each display component so that it can retrieve the correct string(s) using a unique key.

See #489 for an example.

Adding a partial list of pages that need snippets for my own reference – Parker

  • [ ] HomePage.js

ethanbb avatar May 16 '18 01:05 ethanbb

Closed by #521

knod avatar May 22 '18 12:05 knod

Hey @knod, I don't think this is closed actually. What I meant by this issue was to plug in references to the localization object in place of string literals in all the places we have English strings currently, which hasn't been done yet.

ethanbb avatar May 22 '18 12:05 ethanbb

@ethanbb: Isn't that covered by #500? I thought this was to change to a nested object instead of a flat one.

knod avatar May 22 '18 13:05 knod

My impression was that #500 is to actually translate existing English strings into other languages, whereas this issue is to factor remaining string literals in the rest of the codebase out into the English localization file.

ethanbb avatar May 22 '18 13:05 ethanbb

Ah, ok. I'd been thinking of #500 for both, but maybe it's worth separating them.

knod avatar May 22 '18 13:05 knod

Maybe we could turn this into specific assignments - have an issue for each page that still need the localization infrastructure.

knod avatar May 22 '18 13:05 knod

@ethanstrominger , this was probably the issue you should have been referencing all along :/

knod avatar Jul 13 '18 22:07 knod