Ethan Blackwood

So I'm looking at the main branch and I still see those local imports in `spatial.py` including the one causing tons of warnings. Obviously not a huge priority, but can...

Yeah it's just this one: ``` caiman\source_extraction\cnmf\spatial.py:844: DeprecationWarning: Please use grey_dilation from the scipy.ndimage namespace, the scipy.ndimage.morphology namespace is deprecated. from scipy.ndimage.morphology import grey_dilation. (evaluate_components) ``` Maybe it depends on...

You know what, I don't think the `is3D` flag is necessary after all. I just looked again at the load function and realized that `is3D` is only used if the...

Also, slightly off-topic now but: ```python if channel is not None: logging.debug(m.shape) m = m[channel].squeeze() logging.debug(f"Movie shape: {m.shape}") ``` is this clause in `load_movie_chain` ever used at this point? Since...

Hey, thanks for taking a look. I more recently made a discussion #1366 about this channel argument - instead of removing, maybe we should make it more functional? Or what...

@pgunn I think the discussion got a little off track... this is a pretty minor change, do you think we could push this through soon to unblock the corresponding issue...

Looking back at the error: ``` TypeError: float() argument must be a string or a real number, not 'coo_matrix' ``` It seems this happens if `nb != 0` AND `low_rank_background`...

> However, I'm not 100% sure that the behavior of adding indices for background components is correct in the first place, since it seems inconsistent with what happens with no...

> But i don't understand why i didn't meet this while using without binary masks (maybe removing empty component is very rare in that case ?) I think because if...

I think what I would like to do at some point is add tests for both the boolean and non-boolean seed cases, confirm that it currently fails for the boolean...