Binbin

ohh, we already have the history limit: ``` /* The latency time series for a given event. */ struct latencyTimeSeries { int idx; /* Index of the next sample to...

> repl-diskless-load disabled -> on-empty-db. Any drawbacks? Seems to have no drawbacks. Speaking of repl-diskless-load, do we consider adding an empty-db option? it perform a flushall at first so that...

> About latency monitor, enable it is not a big deal. ``` /* Add the sample only if the elapsed time is >= to the configured threshold. */ #define latencyAddSampleIfNeeded(event,...

> repl-diskless-load disabled -> on-empty-db. Any drawbacks? ok, i think the only drawback is that in the past, the replica will store the rdb file to disk, and it will...

> I'd also be okay making this config immutable for Valkey 8.0. We've had security issues in the past with it, which is why we marked it as PROTECTED. It...

> Immutable is OK, as long as it works to set --dir multiple times at startup, in config file and on command line. I know the Fedora (or Debian?) maintainer...

Yes, this is indeed one of the uses of dir modification, i suddenly forgot about it. Speaking of read-only disk error, it will cause cluster-config-file saving to fail and cause...

ok, the link is #635, i take it wrong.

ok, now there seem to be three options now: 1. Keep it mutable, add valkey.conf to explain the harm of modifying it 2. Keep it mutable, block it when there...

> @enjoy-binbin also mentioned logging: the child process will continue logging in the old dir. That seems like no problem to me. Will anything happen to RDB files? No crashes?...