valkey icon indicating copy to clipboard operation
valkey copied to clipboard

Change all the lazyfree configurations to yes by default

Open enjoy-binbin opened this issue 1 year ago • 3 comments

Set replica-lazy-flush and lazyfree-lazy-user-flush to yes by default.

There are many problems with running flush synchronously. Even in single CPU environments, the thread managers should balance between the freeing and serving incoming requests.

Set lazy eviction, expire, server-del, user-del to yes by default

We now have a del and a lazyfree del, we also have these configuration items to control: lazyfree-lazy-eviction, lazyfree-lazy-expire, lazyfree-lazy-server-del, lazyfree-lazy-user-del. In most cases lazyfree is better since it reduces the risk of blocking the main thread, and because we have lazyfreeGetFreeEffort, on those with high effor (currently 64) will use lazyfree.

Part of #653.

enjoy-binbin avatar Aug 14 '24 14:08 enjoy-binbin

full ci: https://github.com/valkey-io/valkey/actions/runs/10389867384

enjoy-binbin avatar Aug 14 '24 14:08 enjoy-binbin

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.16%. Comparing base (131857e) to head (02121d9). Report is 55 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #913      +/-   ##
============================================
- Coverage     70.37%   70.16%   -0.21%     
============================================
  Files           112      112              
  Lines         61492    61490       -2     
============================================
- Hits          43273    43146     -127     
- Misses        18219    18344     +125     
Files with missing lines Coverage Δ
src/config.c 78.69% <ø> (ø)

... and 24 files with indirect coverage changes

codecov[bot] avatar Aug 14 '24 15:08 codecov[bot]

@valkey-io/core-team I guess let's vote on all of these. This sounds like a good change to me.

madolson avatar Aug 14 '24 20:08 madolson