valkey
valkey copied to clipboard
Migrate listpack.c unit tests to new test framework
This PR migrates all tests related to listpack.c into new test framework as part of the parent issue #428.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 69.80%. Comparing base (
138a7d9
) to head (b271ce2
). Report is 255 commits behind head on unstable.
Additional details and impacted files
@@ Coverage Diff @@
## unstable #484 +/- ##
============================================
+ Coverage 69.78% 69.80% +0.02%
============================================
Files 109 109
Lines 61795 61795
============================================
+ Hits 43122 43138 +16
+ Misses 18673 18657 -16
Files with missing lines | Coverage Δ | |
---|---|---|
src/listpack.c | 91.57% <ø> (+1.51%) |
:arrow_up: |
src/server.c | 88.60% <ø> (ø) |
@b1zantine Looks like the build is failing, can you double check it's working when you run:
make valkey-unit-tests
@madolson make valkey-unit-tests
exits with code 0 when there are warnings. The CI workflows failed since we are passing the flag to treat warnings as errors. I have fixed the issues and verified it by running make valkey-unit-tests SERVER_CFLAGS='-Werror'
. The CI workflows should succeed now.
sorry, i just merged #949 since Wen did a fresher review, i didn’t notice this PR...