SteamCAD icon indicating copy to clipboard operation
SteamCAD copied to clipboard

Published 20 hours ago • verified publisher icon oskardolch

reserved identifier violation

Open elfring opened this issue 4 years ago • 6 comments

I would like to point out that an identifier like “_DPARSER_HPP_” does not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

elfring avatar Apr 04 '20 05:04 elfring

Is there any serious issue with this? I mean if there are problems compiling the code with a particular compiler. If yes, I have no problems to change it. If not, I don't care.

oskardolch avatar Apr 08 '20 20:04 oskardolch

How do you think about to avoid that this software depends on undefined behaviour?

elfring avatar Apr 09 '20 05:04 elfring

I don't feel like this is an issue at the moment. As long as the compiler does not complain, then I believe it knows what to do.

oskardolch avatar Apr 21 '20 19:04 oskardolch

I suggest to reduce the tampering with the reserved name space.

elfring avatar Apr 21 '20 20:04 elfring

I think I more or less follow those rules. The preprocessor directives are not mentioned there, and I don't use double underscore at the beginning of the symbols. Can you explain a bit more the intention of your effort?

oskardolch avatar Apr 21 '20 20:04 oskardolch

How do you think about to achieve that your software will become standard compliant also according to another implementation detail?

elfring avatar Apr 22 '20 05:04 elfring