Markus Elfring

Results 791 issues of Markus Elfring

The generated files provide information about socket options for all network connections. How would you like to support the checking only for a single connection (without producing more network data...

I would like to clarify software development options [according to a discussion offer](https://github.com/veithen/knetstat/commit/eb65ef89c8a30b5bd8d814ae758b91c6dac8777a#commitcomment-35185950 "Improvements"). :crystal_ball: Which data formats would you like to consider any further for corresponding network analysis tools?

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://262.ecma-international.org/12.0/#sec-assignment-operators "Description for assignment operators") accordingly....

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....

Two text input fields are provided for the functionality “search and replace”. I would appreciate if they can occasionally be extended for the input of multi-line data.

Feature

[An extra null pointer check is not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") in [the destructor for the class “Priv”](https://github.com/vinipsmaker/tufao/blob/76e881c9e1a0428757f21c3230fa90134d0157e9/src/priv/websocket.h#L291 "Update candidate: Destructor for Priv").

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....

Would you like to add more error handling for return values from functions like the following? - [fprintf](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html) ⇒ [gsm_print](https://github.com/LubosD/twinkle/blob/4f4ff22bb992b6a3443bc2288436547db9e223e2/src/audio/gsm/src/gsm_print.cpp#L131) - [strdup](http://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html) ⇒ [write_cmd_to_socket](https://github.com/LubosD/twinkle/blob/4f4ff22bb992b6a3443bc2288436547db9e223e2/src/cmd_socket.cpp#L156)

code quality

[Extra null pointer checks are not needed](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null) in [the destructor for the class "t_log"](https://github.com/LubosD/twinkle/blob/42678b3346f05c3cce3915989b1057785bde989e/src/log.cpp#L97). Are there any more update candidates to consider if [the usage of a macro like "`MEMMAN_DELETE`"](https://github.com/LubosD/twinkle/blob/4f4ff22bb992b6a3443bc2288436547db9e223e2/src/audits/memman.h#L28)"...

code quality

I would like to point out that identifiers like "[`_PHONE_H`](https://github.com/LubosD/twinkle/blob/2af8b4b6b3b09ae4f73d3d38204619f1486d8a89/src/phone.h#L19)" and "[`_SUBSCRIPTION_H`](https://github.com/LubosD/twinkle/blob/2af8b4b6b3b09ae4f73d3d38204619f1486d8a89/src/subscription.h#L24)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C++ language standard. Would you like to adjust...

code quality