Markus Elfring

Direct return value check after AC_PATH_PROG

1

Would it be a bit safer to [combine the macro call "AC_PATH_PROG"](https://github.com/taviso/ctypes.sh/blob/7ca086bd15981d76a36e3e7996b878786189e2ba/configure.ac#L29) with [a "not found action"](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Common-Shell-Constructs.html#index-AS_005fIF-1574)? How do you think about to check the retrieved return value for [the...

I would like to point out that an identifier like “[`__infrastructure_HPP`](https://github.com/scipr-lab/libsnark/blob/2af440246fa2c3d0b1b0a425fb6abd8cc8b9c54d/libsnark/gadgetlib2/infrastructure.hpp#L18 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....

Check for async-signal-safety

1

I see in [a source file](https://github.com/bmc/daemonize/blob/26a094a86d8f3ac70b617c8fe96f53d01e625830/daemonize.c#L498) that functions like "fopen" and "getenv" are used before the function "execvp" will be called. Would you like to improve your program design if...

I would like to point out that identifiers like "[`_CONFIG_H_`](https://github.com/bmc/daemonize/blob/d87e7e6a69a2b2dd4936747067806e46368d9ac6/acconfig.h#L10)" and "[`__DAEMONIZE_FLOCK_H__`](https://github.com/bmc/daemonize/blob/4f0905d8a8d8ff47d6b9f16dd76cf144030290ca/flock.h#L14)" [do not fit](https://www.securecoding.cert.org/confluence/display/seccode/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...

Improve exception safety with smart pointers

2

Would you like to [wrap any pointer data members](https://github.com/tum-vision/LDSO/blob/9718e5c54d32e39d3a26c0cab1ef9e064fd0f4bb/src/frontend/PixelSelector2.cc#L9 "Update candidate: PixelSelector class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?

Remove unnecessary null pointer checks

5

[Extra null pointer checks are not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [AccumulatedSCHessianSSE](https://github.com/tum-vision/LDSO/blob/9718e5c54d32e39d3a26c0cab1ef9e064fd0f4bb/include/internal/OptimizationBackend/AccumulatedSCHessian.h#L30 "Destructor for AccumulatedSCHessianSSE") - [EnergyFunctional](https://github.com/tum-vision/LDSO/blob/9718e5c54d32e39d3a26c0cab1ef9e064fd0f4bb/src/internal/OptimizationBackend/EnergyFunctional.cc#L18 "Destructor...

Remove unnecessary null pointer checks

1

[Extra null pointer checks are not needed in functions](https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null "Do I need to check for null before delete p?") like the following. - [PhotometricUndistorter](https://github.com/tum-vision/mono_dataset_code/blob/3feba2f77488e5b3e05c739c2c7afb57822ad083/src/PhotometricUndistorter.cpp#L158 "Destructor for PhotometricUndistorter") - [UndistorterFOV](https://github.com/tum-vision/mono_dataset_code/blob/3feba2f77488e5b3e05c739c2c7afb57822ad083/src/FOVUndistorter.cpp#L273 "Destructor...

Improve exception safety with smart pointers

1

Would you like to [wrap any pointer data members](https://github.com/tum-vision/mono_dataset_code/blob/3feba2f77488e5b3e05c739c2c7afb57822ad083/src/BenchmarkDatasetReader.h#L86 "Update candidate: DatasetReader class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....