devshop icon indicating copy to clipboard operation
devshop copied to clipboard

Use another variable assignment with a combined operator for string concatenations

Open elfring opened this issue 4 years ago • 4 comments

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to increase the usage of combined operators accordingly.

diff --git a/src/DevShop/Command/DevmasterUpgrade.php b/src/DevShop/Command/DevmasterUpgrade.php
index 2ac7a15ef..308b459a1 100644
--- a/src/DevShop/Command/DevmasterUpgrade.php
+++ b/src/DevShop/Command/DevmasterUpgrade.php
@@ -156,7 +156,7 @@ class DevmasterUpgrade extends Command
         $number++;
       }
       $output->writeln("File DOES NOT exists at " . $target_path . '-' . $number);
-      $target_path = $target_path . '-' . $number;
+      $target_path .= '-' . $number;
     }
 
     $output->writeln('');

elfring avatar Nov 26 '21 20:11 elfring

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

stale[bot] avatar Jun 12 '22 11:06 stale[bot]

:crystal_ball: Will the chances grow to adjust the shown assignment statement?

elfring avatar Jun 12 '22 13:06 elfring

This issue is no longer marked for closure.

stale[bot] avatar Jun 12 '22 13:06 stale[bot]

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

stale[bot] avatar Sep 21 '22 07:09 stale[bot]

This issue has been marked 'stale' due to lack of recent activity. If there is no further activity, the issue will be closed in another 30 days. Thank you for your contribution!

stale[bot] avatar Dec 24 '22 08:12 stale[bot]

This issue has been closed due to inactivity. If you feel this is in error, please reopen the issue or file a new issue with the relevant details.

stale[bot] avatar Mar 25 '23 08:03 stale[bot]