Markus Elfring
Markus Elfring
I would like to point out that an identifier like “[`_SPTAG_CORE_COMMONDEFS_H_`](https://github.com/microsoft/SPTAG/blob/d2eadc747c3d6b7bba6dedf5e00f7e3654cd8e75/AnnService/inc/Core/Common.h#L4 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to...
Would you like to [wrap any pointer data members](https://github.com/microsoft/SPTAG/blob/d2eadc747c3d6b7bba6dedf5e00f7e3654cd8e75/AnnService/inc/Core/Common/BKTree.h#L48 "Update candidate: KmeansArgs class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
I would like to point out that an identifier like “[`_PLH_CPP_MSC`](https://github.com/vovkos/protolesshooks/blob/31a9ffd95bc27f17be0b174dd7c4af411e3aa805/include/plh_Def.h#L5 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler implementation.") to the...
I would like to point out that an identifier like “[`__NBLA_SOLVER_HPP__`](https://github.com/sony/nnabla/blob/4fb5defc38f6cbe4c772d7ac4170450235786a07/include/nbla/solver.hpp#L17 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the...
Would you like to [replace any double quotes](https://github.com/jscheiny/Streams/blob/a23f201015e29cdcf08b8e32c6e858eed85a9a08/source/Stream.h#L4) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?
I would like to point out that identifiers like "[`_H_FASTERHTTP_`](https://github.com/calvinwilliams/hetao/blob/029690fe2638a7568483ea3c9f768dd1c1b7b845/src/fasterhttp.h#L6)" and "[`_H_HETAO_IN_`](https://github.com/calvinwilliams/hetao/blob/029690fe2638a7568483ea3c9f768dd1c1b7b845/src/hetao_in.h#L9)" [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29) to the expected naming convention of the C language standard. Would you like to adjust...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....
Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html) ⇒ [node_pair_new](https://github.com/matz/streem/blob/ee3edae904188893941828a31e8665b41160e6a5/src/node.c#L69) - [fputs](http://pubs.opengroup.org/onlinepubs/9699919799/functions/fputs.html) ⇒ [print_id](https://github.com/matz/streem/blob/34645324a2fb23f44c9ada1aef0e0728e4ba45db/src/main.c#L5)
Would you like to add more error handling for return values from functions like the following? - [fprintf](https://pubs.opengroup.org/onlinepubs/9699919799/functions/fprintf.html "Print formatted output") ⇒ [zbc_print_device_info](https://github.com/westerndigitalcorporation/libzbc/blob/0826923e4c486ab6ab3435f20b71f7a5d8f3598d/lib/zbc.c#L402) - [strdup](https://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html "Duplicate a string.") ⇒ [zbc_block_handle_partition](https://github.com/westerndigitalcorporation/libzbc/blob/0826923e4c486ab6ab3435f20b71f7a5d8f3598d/lib/zbc_block.c#L202)
[The macro "AC_INIT"](https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Initializing-configure.html) supports that the needed version information is determined by specific macro calls before. Would you like to [reuse anything from the current autoconf approach](http://git.savannah.gnu.org/gitweb/?p=autoconf.git;a=blob;f=configure.ac;h=e7029ebc87c5f3821b857f4028621bd34cd0b245;hb=57ec362325a9b58d719c834d06653cfa7e2aa894#l21) for [your build...