LDSO icon indicating copy to clipboard operation
LDSO copied to clipboard

Improve exception safety with smart pointers

Open elfring opened this issue 4 years ago • 2 comments

Would you like to wrap any pointer data members with the class template “std::unique_ptr”?

elfring avatar Mar 23 '20 17:03 elfring

Please see my comment: https://github.com/tum-vision/LDSO/issues/51#issuecomment-602745613

In general, yes, that is great practice. For this project at this stage probably too intrusive with no real benefit considering development is not active, sorry.

NikolausDemmel avatar Mar 23 '20 17:03 NikolausDemmel

I don't mind trying to fix some and creating pull requests, would it be okay?

t-lou avatar Jul 30 '20 23:07 t-lou