hetao icon indicating copy to clipboard operation
hetao copied to clipboard

reserved identifier violation

Open elfring opened this issue 8 years ago • 8 comments

I would like to point out that identifiers like "_H_FASTERHTTP_" and "_H_HETAO_IN_" do not fit to the expected naming convention of the C language standard. Would you like to adjust your selection for unique names?

elfring avatar Oct 08 '16 18:10 elfring

;)

calvinwilliams avatar Oct 09 '16 13:10 calvinwilliams

How do you think about to avoid that this software depends on undefined behaviour?

elfring avatar Oct 09 '16 13:10 elfring

I fixed it ! ^______________________^

calvinwilliams avatar Oct 09 '16 14:10 calvinwilliams

Which commit will contain corresponding changes?

elfring avatar Oct 09 '16 14:10 elfring

Sorry , I commited it just now

UPDATE TO V0.9.1C BETA

calvinwilliams avatar Oct 09 '16 14:10 calvinwilliams

I find that there are still a few update candidates left over.

elfring avatar Oct 09 '16 15:10 elfring

It's a symbol for nm and grep for find out version directly , I reserved it

calvinwilliams avatar Oct 09 '16 15:10 calvinwilliams

Can your kind of "reservation" work also without the usage of misplaced underscores?

elfring avatar Oct 09 '16 15:10 elfring