Markus Elfring
Markus Elfring
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://perldoc.perl.org/perlop#Assignment-Operators "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
Would you like to add the configuration script “[AX_PTHREAD](https://www.gnu.org/software/autoconf-archive/ax_pthread.html "How to build C programs using POSIX threads")” to [your build specification](https://github.com/Gecode/gecode/blob/e6abc78e625380c433be20d0e115d1074cf5246b/gecode.m4#L1480 "Update candidate")?
[An extra null pointer check is not needed in functions](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") like the following. - [Circulate](https://github.com/fvwmorg/fvwm3/blob/4a639a8648f4f6a2a6273a827f2299c6cccaf30c/fvwm/conditional.c#L88 "Circulate function") - [pop_menu_up](https://github.com/fvwmorg/fvwm3/blob/4a639a8648f4f6a2a6273a827f2299c6cccaf30c/fvwm/menus.c#L3212 "pop_menu_up function")
I would like to point out that identifiers like “[`_EWMH_`](https://github.com/fvwmorg/fvwm3/blob/84499a61dfb37e6f8f2e419cc4a76266d15e8f7a/fvwm/ewmh.h#L4 "Update candidate")” and “[`_MENUS_`](https://github.com/fvwmorg/fvwm3/blob/65ba209215f9b8b27bee38c7382f1999126cc6f1/fvwm/menus.h#L3 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier#DCL37-C.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28IncludeGuard%29 "Do not use identifiers which are reserved for the compiler...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://docs.oracle.com/javase/specs/jls/se17/html/jls-15.html#jls-15.26 "Description for assignment operators") accordingly....
Would you like to add more error handling for return values from functions like the following? - [malloc](http://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [blGenList](https://github.com/MarilynDafa/Bulllord-Engine/blob/2ebb0886c32d4ebc91256e7d912f0c54fda48abe/code/src/list.c#L22) - [pthread_mutex_init](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_mutex_init.html "Initialize a mutex.") ⇒ [blGenMutex](https://github.com/MarilynDafa/Bulllord-Engine/blob/2ebb0886c32d4ebc91256e7d912f0c54fda48abe/code/src/thread.c#L22)
I would like to point out that identifiers like “[`_Vol`](https://github.com/MarilynDafa/Bulllord-Engine/blob/472193459db66e015102f6c572ea8c7f5f614ae7/code/headers/audio.h#L28 "Update candidate")” and “[`__sprite_h_`](https://github.com/MarilynDafa/Bulllord-Engine/blob/c62ba6e103c5e320a625fab11753ec216de98e23/code/headers/sprite.h#L21 "Another update candidate")” [do not fit](https://www.securecoding.cert.org/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler...
# Feature Request :eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....