Markus Elfring

Increase the usage of augmented assignment statements

1

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

Would you like to wrap any pointer data members with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”? Update candidates: - [Asset](https://github.com/Shervanator/Engine/blob/3f9fa86ba7718e8a6ceb7d64e4b18dd610028b99/src/engine/Asset.cpp#L7) - [PhysicsManager](https://github.com/Shervanator/Engine/blob/3f9fa86ba7718e8a6ceb7d64e4b18dd610028b99/src/engine/PhysicsManager.cpp#L11)

Increase the usage of augmented assignment statements

2

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

reserved identifier violation

1

I would like to point out that an identifier like “[`_H_TIRAMISU_CORE_`](https://github.com/Tiramisu-Compiler/tiramisu/blob/c9f4ca9bb6fc1c83427b8361eba31a26b205008f/include/tiramisu/core.h#L1 "Update candidate")” [does eventually not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to...

Use of angle brackets around file names for include statements

2

Would you like to [replace any double quotes](https://github.com/wisk/medusa/blob/52175dbd4ca16d4be3cbe988eb849ed19a4ff334/inc/medusa/medusa.hpp#L4) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?

Complete quoting for parameters of some CMake commands

3

Some parameters (like "[${DOCROOT}/Doxyfile](https://github.com/wisk/medusa/blob/8fda88ce06173055948ebf6691d2143ea9cbc074/CMakeLists.txt#L62)" and "[${INCROOT}/address.hpp](https://github.com/wisk/medusa/blob/06d17f00500c226826a183153abf90b52d7ff5b8/src/core/CMakeLists.txt#L5)") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build...

Use of angle brackets around file names for include statements

4

Would you like to [replace any double quotes](https://github.com/srdja/Collections-C/blob/4a5d1f4b68ec4aa80c797fd57309140867e82210/src/stack.c#L21) by [angle brackets around file names for include statements](http://stackoverflow.com/questions/21593/what-is-the-difference-between-include-filename-and-include-filename)?

Improve cooperation with C++ environments

1

[Some code from C source files](https://github.com/srdja/Collections-C/blob/82883c53a4e303b8bc55a18713db55653828899c/src/slist.h#L24) should be wrapped by the setting '[`extern "C"`](https://isocpp.org/wiki/faq/mixing-c-and-cpp#include-c-hdrs-personal)' for C++ tools, shouldn't it?

Fix signal handler

15

The functions "[exit](http://pubs.opengroup.org/onlinepubs/9699919799/functions/exit.html)" and "[tc_log_info](https://github.com/wangbin579/tcpcopy/blob/f99adabead5b1e6ca7fd66ebb4b4fafac0aa8d5a/src/core/tc_log.c#L46)" do not belong to the list of [async-signal-safe functions](https://www.securecoding.cert.org/confluence/display/seccode/SIG30-C.+Call+only+asynchronous-safe+functions+within+signal+handlers). I guess that a different program design will be needed for your function "[signal_handler](https://github.com/wangbin579/tcpcopy/blob/0d22acd0895e539bedefcaba41a481eec398291b/src/interception/main.c#L50)".

I would like to point out that an identifier like “[`_XPP_STATES_ENDEFFECTORS_H_`](https://github.com/leggedrobotics/xpp/blob/3744510432ec9260309d986f1784f11ddb78dd53/xpp_states/include/xpp_states/endeffectors.h#L30 "Update candidate")” [does not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL51-CPP.Donotdeclareordefineareservedidentifier-NoncompliantCodeExample%28HeaderGuard%29 "Do not declare an identifier which is reserved for the compiler implementation.") to the...