Markus Elfring

Choose an error code according to a wrong depth type

1

[A Python script contains the following statements](https://github.com/iipeace/guider/blob/9d40e1cf4efd86ff13e572d804d0acbf3202ac43/utils/ImplAnalyzer/ImplAnalyzer.py#L173 "Update candidate") at the moment. ```python if not args.depth.isdigit(): SysMgr.printErr('wrong depth type') sys.exit(0) ``` I suggest to [pass an error code to the...

Fix exception handling for the import of essential modules

3

The script “guider.py” contains the following source code at the moment. ```python … try: … import sys … ``` I doubt that the specified exception handling can work if the...

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....

Improve exception safety with smart pointers

1

Would you like to [wrap any pointer data members](https://github.com/hyperion-project/hyperion.ng/blob/c00d8e62fb5a57f57a142fcd51ad5822c8bef544/src/hyperiond/hyperiond.cpp#L63 "Update candidate: HyperionDaemon class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?

Increase the usage of compound assignment operators

2

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of compound operators](https://262.ecma-international.org/12.0/#sec-assignment-operators "Description for assignment operators") accordingly....

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....

reserved identifier violation

6

I would like to point out that identifiers like "[`__COMPRESSOR_H__`](https://github.com/shogun-toolbox/shogun/blob/a0b32218bcb2219d1a61af5e3486567704cb3ae8/src/shogun/lib/Compressor.h#L10)" and "[`_CUSTOMKERNEL_H___`](https://github.com/shogun-toolbox/shogun/blob/a7eb2ec5b4e2cb2da7b640ed152987c5004cf8f8/src/shogun/kernel/CustomKernel.h#L12)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL32-CPP.+Do+not+declare+or+define+a+reserved+identifier#DCL32-CPPDonotdeclareordefineareservedidentifier-NoncompliantCodeExampleHeaderGuard) to the expected naming convention of the C++ language standard. Would you like to adjust...

Improving translation infrastructure for form fields

2

[The labels and messages (for constraints) should be translated for each field](https://symfony-devs.slack.com/archives/C3EQ7S3MJ/p1625484630443200 "Clarification request from 2021-07-05") (which get added in the implementation of the method “buildForm”). ☞ Example: [Form “postal...