Markus Elfring
Markus Elfring
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of combined operators](https://www.php.net/manual/en/language.operators.assignment.php#language.operators.assignment.arithmetic "Description for assignment operators") accordingly....
Would you like to [wrap any pointer data members](https://github.com/jhasse/poly2tri/blob/d949f3cd6f85b20728af0bdc454b090226068c73/poly2tri/sweep/cdt.cc#L35 "Update candidate: CDT class") with the class template “[std::unique_ptr](https://en.wikipedia.org/wiki/Smart_pointer#unique_ptr "Description for the usage of smart pointers")”?
I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing. Would you like to add more error...
I have seen that [no loop is used around a call](https://github.com/irungentoo/toxcore/blob/d69a6843e70bc5c75c343ca54388ced3c1b91662/toxav/toxav.c#L524) of the function "[pthread_cond_wait](http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_cond_wait.html)". Would you like to reuse anything from my message on the topic "[spurious wakeup](http://groups.google.de/group/comp.programming.threads/msg/bb8299804652fdd7)"?
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....
[Extra null pointer checks are not needed in functions](https://stackoverflow.com/questions/18775608/free-a-null-pointer-anyway-or-check-first "Free a null pointer anyway or check first?") like the following. - [list_clients](https://github.com/LibVNC/x11vnc/blob/f07df92816ef10b7382a542125955df7f4156a5c/src/connections.c#L197) - [solid_bg](https://github.com/LibVNC/x11vnc/blob/f07df92816ef10b7382a542125955df7f4156a5c/src/solid.c#L1399) 💭 I am curious if another...
Would you like to add more error handling for return values from functions like the following? - [malloc](https://pubs.opengroup.org/onlinepubs/9699919799/functions/malloc.html "Memory allocation") ⇒ [usr_bin_path](https://github.com/LibVNC/x11vnc/blob/f07df92816ef10b7382a542125955df7f4156a5c/src/solid.c#L75) - [strdup](https://pubs.opengroup.org/onlinepubs/9699919799/functions/strdup.html "Duplicate a string.") ⇒ [terminal_services](https://github.com/LibVNC/x11vnc/blob/f07df92816ef10b7382a542125955df7f4156a5c/src/x11vnc.c#L326)
I would like to point out that identifiers like “[`_X11VNC_PARAMS_H`](https://github.com/LibVNC/x11vnc/blob/f07df92816ef10b7382a542125955df7f4156a5c/src/params.h#L33 "Update candidate")” and “[`_XExtData`](https://github.com/LibVNC/x11vnc/blob/f07df92816ef10b7382a542125955df7f4156a5c/src/nox11.h#L940 "Another update candidate")” [do not fit](https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers which are reserved for the compiler...
:eyes: Some source code analysis tools can help to find opportunities for improving software components. :thought_balloon: I propose to [increase the usage of augmented assignment statements](https://docs.python.org/3/reference/simple_stmts.html#augmented-assignment-statements "Augmented assignment statements") accordingly....