shogun icon indicating copy to clipboard operation
shogun copied to clipboard
verified publisher icon shogun-toolbox

reserved identifier violation

Open elfring opened this issue 12 years ago • 6 comments

I would like to point out that identifiers like "__COMPRESSOR_H__" and "_CUSTOMKERNEL_H___" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

elfring avatar Apr 10 '13 19:04 elfring

We don't mind - but have you met any troubles with it?

lisitsyn avatar Apr 10 '13 19:04 lisitsyn

Would you like to delete any underscores from affected identifiers in your software library?

How do you think about to make your include guards not only standard-compliant but also really unique by appending a kind of UUID?

elfring avatar Apr 10 '13 19:04 elfring

I think a UUID is not necessary then just suffix/prefix stuff with SG to avoid conflicts. But I certainly don't mind having this standardized (but then update the README.developer too)

sonney2k avatar Apr 10 '13 19:04 sonney2k

I'll take care of this (estimate is in a few weeks)

lisitsyn avatar Apr 10 '13 19:04 lisitsyn

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Feb 26 '20 19:02 stale[bot]

How do you think about to avoid that this software depends on undefined behaviour?

elfring avatar Feb 26 '20 19:02 elfring