David Tolnay
David Tolnay
I don't know what you are advocating. Whether the one case is very clear is irrelevant – the existence of a very clear case does not eliminate the large net...
I am advocating for the cc crate to not change in response to this issue — I think "too bad" is roughly the appropriate response. Anyone is free to redistribute...
On the `backtrace()` function -- one thing I would like in std is a constructor on Backtrace to cheaply make a backtrace with `Disabled` status. Does that help here? That...
Sounds good to me. Could you make sure to publish release notes or a changelog for eyre, including retroactively for the past couple releases if possible? I noticed there have...
`anyhow!` handles the conversion. ```rust use anyhow::anyhow; fn main() { let e: Box = unimplemented!(); let e = anyhow!(e); } ```
If you need an `Error` trait impl, you need to use https://github.com/dtolnay/thiserror. ```rust #[derive(Error, Debug)] #[error(transparent)] struct Error(#[from] anyhow::Error); fn b() { a(Error(anyhow!("foo"))); } ```
Last good build: https://travis-ci.com/dtolnay/argv/jobs/277304972 First bad build: https://travis-ci.com/dtolnay/argv/jobs/277521343
I think the same failure is still there: https://github.com/dtolnay/argv/runs/4146600747. ```console thread 'test' panicked at 'assertion failed: `(left == right)` left: `""`, right: `"target/x86_64-apple-darwin/debug/examples/print\na\nb\nc\n"`', tests/test.rs:31:5 ``` On the master branch a6f326cd15728ac437e43c02670ae97f52b32b14...
No. The logic in your `cfg` changes is not correct.
I've published a fix in async-trait 0.1.55.